helium / hotspot-app

Helium hotspot app for iOS and Android
https://www.helium.com
Apache License 2.0
187 stars 138 forks source link

Deep link from Maker app not working on Android 12 devices #1237

Closed lxie123 closed 2 years ago

lxie123 commented 2 years ago

Describe the bug on Android 12 devices, when linking to helium app with our maker app, it opens chrome instead and we get a 404. With android 11 devices, things seem okay. It seems like helium app is not setting itself as default for opening these kind of links on Android 12.

To Reproduce

  1. Launch maker app on android 12 devices
  2. link wallet
  3. No prompt to open with helium
  4. Chrome opens with 404

Expected behavior Helium app should open with request to link wallet

Screenshots If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

lxie123 commented 2 years ago

the supported links is missing on Android 12 Android 12 screenshot: image

Android 11 screenshot: image

leadtekjun commented 2 years ago

same for me, any solution?

leadtekjun commented 2 years ago

the default link for maker app to login is: https://www.helium.com/link_wallet?appName=Maker%20App&callbackUrl=makerappscheme%3A%2F%2F&requestAppId=com.maker.makerapp do we need to change some params in the link?

leadtekjun commented 2 years ago

oh, seems like the latest commit fixed this, waiting for the release.

ChunChiehKung commented 2 years ago

Hi Sir, I still can see this issue. Is there any updates for it? Thanks a lot.

adisaro commented 2 years ago

guys, this bug is preventing people with android 12 to use the maker app, are you aware of this?

tyler-whitman commented 2 years ago

guys, this bug is preventing people with android 12 to use the maker app, are you aware of this?

We found the issue and it will be resolved soon, auto verification of our app links was failing. In the meantime users are able to manually verify the app link until the auto verification is working properly.

enable_link

tyler-whitman commented 2 years ago

This is now resolved, the verified link is working properly on install. If you are still having issues please check the deeplink settings shown above and add helium.com as a link or reinstall the helium app which will check the verified links again and enable helium.com.