helium / hotspot-app

Helium hotspot app for iOS and Android
https://www.helium.com
Apache License 2.0
185 stars 138 forks source link

Transfer Hotspot Support in Helium HNT Wallet #1347

Open oosui opened 1 year ago

oosui commented 1 year ago

Since the Helium Hotspot App will sunset some day, what's the plan of supporting transfer hotspot in Helium HNT Wallet? By the way can the Helium HNT Wallet sign an add gateway transaction now?

Ryan-Goldstein commented 1 year ago

Manufacturers’ apps, which sign the transactions through deeplinking with the Helium Wallet app, will be needed to transfer hotspots in the future.

oosui commented 1 year ago

Thans @Ryan-Goldstein

navToAppLink support AppLinkPayment, https://github.com/helium/hotspot-app/blob/afbe3342b4b663787ae379e143a145704bd32067/src/providers/AppLinkProvider.tsx#L140

But parseUrl only takes parameters as PaymentV1, https://github.com/helium/hotspot-app/blob/afbe3342b4b663787ae379e143a145704bd32067/src/providers/AppLinkProvider.tsx#L198

Shouldn't it be parsed to support record with PaymentV2 parameters?