search

helium / maker-starter-app

Apache License 2.0
36 stars 39 forks source link

onboardType Web missing? #13

Closed cokes518 closed 2 years ago

cokes518 commented 2 years ago

I was cleaning up the docs to add the maker app, and there's no maker app equivalent for web onboarding. https://github.com/helium/maker-starter-app/blob/main/src/makers/example/hotspots.ts#L6

niamiot commented 2 years ago

As far As I understand, web onboarding seems supported (OnBoardType can be 'WEB')....

https://github.com/helium/maker-starter-app/blob/ce76e0a5509490caad0f657d80140a70545cf513/src/makers/hotspotMakerTypes.ts#L7

There is also a onboardUrl where url can be precised

https://github.com/helium/maker-starter-app/blob/ce76e0a5509490caad0f657d80140a70545cf513/src/makers/hotspotMakerTypes.ts#L20

cokes518 commented 2 years ago

thanks for the catch. closing.