helium / maker-starter-app

Apache License 2.0
36 stars 39 forks source link

universal linking not working on android 12 #36

Open ChunChiehKung opened 2 years ago

ChunChiehKung commented 2 years ago

Hi Sir,

There is a 404 error when the Maker App try to use deep link to Helium App. 78623

We use the Android ADB to catch the log as below:(However, it looks not related to the 404 error)

transform[stderr]: https://github.com/browserslist/browserslist#browsers-data-updating BUNDLE ./index.js

WARN new NativeEventEmitter() was called with a non-null argument without the required addListener method. WARN new NativeEventEmitter() was called with a non-null argument without the required removeListeners method. WARN new NativeEventEmitter() was called with a non-null argument without the required addListener method. WARN new NativeEventEmitter() was called with a non-null argument without the required removeListeners method. LOG Running "XXXXXX" with {"rootTag":1} WARN new NativeEventEmitter() was called with a non-null argument without the required addListener method. at LanguageProvider (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.XXXXXX.makerapp&modulesOnly=false&runModule=true:313219:24) at render at RCTView at View at RCTView at View at AppContainer (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.XXXXXX.makerapp&modulesOnly=false&runModule=true:76768:36) at XXXXX(RootComponent) (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.XXXXXX.makerapp&modulesOnly=false&runModule=true:83149:28) WARN new NativeEventEmitter() was called with a non-null argument without the required removeListeners method. at LanguageProvider (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.XXXXXX.makerapp&modulesOnly=false&runModule=true:313219:24) at render at RCTView at View at RCTView at View at AppContainer (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.XXXXXX.makerapp&modulesOnly=false&runModule=true:76768:36) at XXXXXX(RootComponent) (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.XXXXXX.makerapp&modulesOnly=false&runModule=true:83149:28) LOG create ble manager LOG setting ble log level to verbose LOG manager create ERROR Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function. in HeliumActionSheet (at MoreListItem.tsx:99)

The App Screenshot:

unnamed (2)

tyler-whitman commented 2 years ago

We found the issue and it will be resolved soon, auto verification of our app links was failing. In the meantime users are able to manually verify the app link until the auto verification is working properly.

enable_link

xiaoye-x commented 2 years ago

I tried to manually set the link in Helium but the problem is the same. If I use sensecap: https://docs.sensecapmx.com/m1/sensecap-hotspot-app/sensecap-hotspot-app . It works ok, no need to manually set the link. So maybe there is some configure error in this Maker APP?

tyler-whitman commented 2 years ago

Yes some config must be incorrect in your maker app. I just verified on Android 12 and this is now resolved, the verified link is working properly on install of the Helium app. If you are still having issues please check the deeplink settings shown above and add helium.com as a link or reinstall the helium app which will check the verified links again and enable helium.com.

If you are still having the problem you must have something wrong with your deeplink config in your maker app.

xiaoye-x commented 2 years ago

Can you specify the detail of the deep link that need to use? The best is the current source code already has the correct one already.

tyler-whitman commented 2 years ago

Can you specify the detail of the deep link that need to use? The best is the current source code already has the correct one already.

So the link doesn't open when using your version of the maker app, but it does when using sensecap? That is pretty odd since handling of the helium.com link should be the same if you have the Helium App installed. With a fresh clone of the maker app is it working? I just tested and it does for me. Do you have another phone you can try?

You need to change makerappscheme to whatever you want your maker app scheme to be. makerappscheme is the example and should not be used. If you search for makerappscheme you will see the integration of deep linking. You should also review https://developer.android.com/training/app-links/deep-linking and https://developer.android.com/training/app-links for Android help.