helium / miner

Miner for the helium blockchain
Apache License 2.0
607 stars 265 forks source link

Default miner configuration is still outdated after many releases #1874

Open disk91 opened 1 year ago

disk91 commented 1 year ago

The miner default configuration is still outdated with

{gateways_run_chain, true}
{gateway_and_mux_enable, false}, 

this impacts the DiY miner with a high risk to make them not working and forcing a manual boring operation on any update. As a consequence it prevent us to correctly follow the updates. I don't see the reason to keep outdated default parameters by default ?

shawaj commented 1 year ago

@disk91 how are you updating?

Take a look at our miner start script which optionally pulls in the right config for different hardware:

https://github.com/NebraLtd/hm-miner/blob/master/start-miner.sh

You can use our prebuilt container too if you want as it's built from the same base

disk91 commented 1 year ago

The problem of overriding the sys.config it that you have to verify everytime if it has changed and you have a high risk of problem. So default setting should work. and curently the default setting are refering to chain configuration that ar not any more viable and that will never be viable in the future It seems simple to make the default config to comply with working parameters and we won't have to override and create a risk of problem later on.

shawaj commented 1 year ago

You can put partial overrides in there.

I.e. you can just update the two pieces you want to.

Similar to this: https://github.com/NebraLtd/hm-miner/blob/master/docker.config

disk91 commented 1 year ago

I can manually do anything .. I basically do it manually My point is to avoid to make manual things because of invalid default settings.

I don't really think that changing two lines in the default config.sys file to reflect the current network setup as a default requires workaround and long discussion.

Do I need to clone and pull request ?

shawaj commented 1 year ago

Maybe, it's not my repo I was just trying to help you out.

But by doing the two line thing I mentioned, you don't have to do it manually every time. It's just a one off. So basically solves any manual intervention after the first time.