search

helium / network-explorer

https://explorer.helium.com
Apache License 2.0
56 stars 25 forks source link

Add hotspot rewards #34

Closed 0lav closed 1 year ago

0lav commented 1 year ago

hotspot 24/hour rewards are already there, might as well show them.

mbthiery commented 1 year ago

Thanks for jumping into the code and submitting this PR. Good callout that this is an easy add.

We'll coordinate with Hotspotty to confirm this data is accurate (atm those numbers seem too low for IOT and instead look like HNT rewards) and on getting the styles in line with the rest of the app.

0lav commented 1 year ago

I do think it is currently HNT value, but I'm guessing they haven't gotten to updating it yet. The live explorer must be using a different API than the github example, the stats shown are different. It would be nice if Hotspotty could provide some basic reward info so people can see it before being redirected to their website.

On Thu, Apr 20, 2023 at 1:58 PM mbthiery @.***> wrote:

Thanks for jumping into the code and submitting this PR. Good callout that this is an easy add.

We'll coordinate with Hotspotty to confirm this data is accurate (atm those numbers seem too low for IOT and instead look like HNT rewards) and on getting the styles in line with the rest of the app.

— Reply to this email directly, view it on GitHub https://github.com/helium/network-explorer/pull/34#issuecomment-1516940428, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMQKPVETHULCVQZ7HJMPKLXCGPPBANCNFSM6AAAAAAXE3HXRM . You are receiving this because you authored the thread.Message ID: @.***>

dansku commented 1 year ago

Hey guys, indeed let's wait until the data is populated correctly