helium / oracles

Oracles for Helium subDAOs
Apache License 2.0
18 stars 21 forks source link

mismatch for SP boosted hexes with rate 1.0 and HIP103 implementation #763

Closed riobah closed 5 months ago

riobah commented 6 months ago

If the SP decides to boost some Mexico hexes with 1.0 rate, HIP103 says we should reward them. Checking the code I could not be sure if we'd actually do it.

HIP103:

if a res12 hex is boosted by a Service Provider of ≥1, the Oracle Multiplier will automatically be 1.00X

code:

                let oracle_multiplier = if boost_multiplier > 1 {
                    dec!(1.0)
                } else {
                    urbanization_multiplier(cl.urbanized)
                };

> vs

bbalser commented 5 months ago

https://github.com/helium/oracles/pull/764 should have solve this problem.