search

helium / oracles

Oracles for Helium subDAOs
Apache License 2.0
19 stars 21 forks source link

Make hex_assignments (boosting_oracles) as separate create #807

Closed kurotych closed 4 months ago

kurotych commented 4 months ago

It makes it possible to reuse hex_assignments code without bloated mobile-verifier dependencies (which causes dependency conflict issues)

bbalser commented 4 months ago

I think we should rename the crate hex_assignments rather than boosting_oracles. I didn't like that name before, but I really don't like it as a crate.

kurotych commented 4 months ago

if #760 is likely to get merged soon it might be less trouble to wait until then and recut this

Maybe it is worth moving "boosting_oracles" to a separate crate in your PR? @maplant

Since this module was reworked there.

maplant commented 4 months ago

@kurotych do you want to use the DataSetDownloader, or would you rather we keep that in mobile_verifier? If you plan on using it for updating the data sets we'd be happy to include it, but it would bring in a rather large set of dependencies with it

kurotych commented 4 months ago

but it would bring in a rather large set of dependencies with it

It is definitely what I don't want. I can't use the mobile_verifier as a dependency in my project because of dependency conflicts, that's why I want to create a separate crate.

do you want to use the DataSetDownloader, or would you rather we keep that in mobile_verifier

If it brings a lot of deps I believe it is worth keeping it in the mobile_verifier for now.

What I need is hex_assignments logic with a minimal amount of dependencies to use in my project.

Feel free to finish #760 in your way, I don't want to interrupt you. I'll investigate what I can do after you merged your PR.