Open anthonyra opened 2 years ago
If the miner restarts the client connections would indeed be dropped, so the only additional concern here would be if there were somehow a name collision that would trigger a restart that the validator otherwise wouldn't have had.
The biggest concern here I can think of would be the lack of compatibility between pg
and pg2
; I'm not familiar with the reasoning behind having both versions supported (OTP versions older than 23) but that feature wouldn't be available on the (ironically older) pg2
It does appear that scope isn't an option for the older pg2
... now it's not a game changer based on how the topics are generated but it would have been an easier "filter"
@jeffgrunewald @andymck thoughts?
https://github.com/helium/sibyl/blob/73ce7b355a1d8864f4c0d211a62ca85418629ac9/src/sibyl_bus.erl#L22
I was poking around in Sibyl to understand how to view which gateways are connected to the durable validator better then using,
or similar.
I was able to hack a working list of gateways based on the sibyl code, but adding a scope will help tremendously. Only concern is that there's a note on the PG man page of Erlang.
Which tells me it's an ETS table and on restarts of the miner could lead to dropped client connections to the validators. However, shouldn't this already be the case?
TL;DR - Would it make sense if I did a PR to add a scope to the PG to make tracking connected hotspots easier or was there a reason it wasn't done from the get go?
Here's the hacky work around for now...