helium / sx1302_hal

SX1302 Hardware Abstraction Layer and Tools (packet forwarder...)
Other
38 stars 45 forks source link

Support u-blox GPS I2C interface #1

Closed JayKickliter closed 4 years ago

JayKickliter commented 4 years ago

Overview

This PR allows the user to configure the SX1302 packet forwarder to use a u-blox GPS with the I2C interface instead of just TTY.

Currently, one signals to the forwarder that a GPS is available by adding the following line to the gateway_conf section in global_config.json:

        "gps_tty_path": "/dev/tty<N>",

Alternatively, the user can now specify a different (and mutually exclusive) parameter:

        "gps_i2c_path": "/dev/i2c-<N>",

Remaining

For Reviewers

The most important changes in this PR hidden by default and easily overlooked when skimming the diff tab above: libloragw/src/loragw_gps.c and packet_forwarder/src/lora_pkt_fwd.c

fvasquez commented 4 years ago

QUESTION rip out NMEA parsing? We did with the SX1301 packet forwarder, but the SX1302 version actively maintained and we may want to upstream

I say keep the NMEA parsing for those folks who may not have a u-blox GPS module.