search

helium / sx1302_hal

SX1302 Hardware Abstraction Layer and Tools (packet forwarder...)
Other
36 stars 44 forks source link

change eu config values to reflect output power #8

Closed refugeesus closed 3 years ago

refugeesus commented 3 years ago

Change values in EU868 config file to reflect output power designated by the key.

Vagabond commented 3 years ago

@JayKickliter can we land this, perhaps?

refugeesus commented 3 years ago

I increased the rssi and snr output value resolution to 3 decimal places and stopped rounding rssi. We round and clip to one decimal place currently. A float is currently supported in proto and miner takes a generic number() type so upstream shouldn't see this value any differently.

JayKickliter commented 3 years ago

@Vagabond we could, but that last commit is unrelated. @refugeesus If we do need that last commit, TX_BUFF_SIZE should be increased by however many characters the new format specifiers would allow.

JayKickliter commented 3 years ago

I reverted my approval just to make sure this config doesn't start being used before checking that it works.

JayKickliter commented 3 years ago

Closing as this PR was superceded by #12