helium / wallet-app

Apache License 2.0
59 stars 35 forks source link

Burn HNT -> DC screens need to support solana #42

Closed Perronef5 closed 1 year ago

Perronef5 commented 2 years ago

Burn HNT to DC screens should support Solana.

lytzV commented 1 year ago

When switched to Solana, instead of an origin wallet burning HNT into DC towards the destination wallet, what happens is the origin wallet holds the DC but only delegates it to the destination wallet.

lytzV commented 1 year ago

@dannpl are you interested in taking this on?

dannpl commented 1 year ago

Go!

lytzV commented 1 year ago

Lovely! I'll follow up w/ more detail describing the feature by EOW

lytzV commented 1 year ago

@dannpl

Timeline

This is a critical feature for the L1 transition that needs be completed & tested by 02/24/2023

Users

Any person that may want to mint & delegate Data Credits, which could include LNS (LoRaWAN Network Server) operators, roaming partners, their customers or any person executing this transaction on their behalf

User Flow

Most of the UI is there already, just need to repurpose them so they are compatible with the Solana narrative See Figma Prototype here

Appendix

A primer on Solana Programming by Noah

Let me know if you have questions or need more context. We can sync over a call as well.

dannpl commented 1 year ago

Heyy, thank you very much for these updates. @lytzV

lytzV commented 1 year ago

@dannpl any questions about the user flow?

let's set up a weekly sync starting next week, what time works best for you?

dannpl commented 1 year ago

Heyy, for now no doubt, I'm going to finish #99 today and I'll start this one.

I think 16:00~16:30 WET.

lytzV commented 1 year ago

Just sent you a friend request on Discord!

dannpl commented 1 year ago

Hy, I lost access to figma!

And my wallet needed to be present here in betaAccess to show the menu.

Screenshot 2023-02-02 at 13 06 34 Screenshot 2023-02-02 at 13 09 17

Without these things it's hard to help

cokes518 commented 1 year ago

Send me your email and I’ll reinvite you.


From: Daniel Cardoso @.> Sent: Thursday, February 2, 2023 5:09:07 AM To: helium/wallet-app @.> Cc: Subscribed @.***> Subject: Re: [helium/wallet-app] Burn HNT -> DC screens need to support solana (Issue #42)

Hy, I lost access to figma!

And my wallet needed to be present here in betaAccess to show the menu. [Screenshot 2023-02-02 at 13 06 34]https://user-images.githubusercontent.com/37663993/216333058-7778665e-7ea2-41af-a059-892d2453d6ba.png

[Screenshot 2023-02-02 at 13 05 36]https://user-images.githubusercontent.com/37663993/216332898-bf42e549-bedf-4e90-a1ca-ccfe7c2e9ea8.png

Without these things it's hard to help

— Reply to this email directly, view it on GitHubhttps://github.com/helium/wallet-app/issues/42#issuecomment-1413719299, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AETPRSQIGO6LRWUEQIYGTSDWVOWXHANCNFSM6AAAAAASBCYTLA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Perronef5 commented 1 year ago

So spoke to @lytzV & @dannpl offline and we agreed the experience should be as follows:

  1. User navigates to swap screen and swaps HNT -> DC by calling the mintDataCredits function as was done for xNFT here https://github.com/helium/helium-program-library/blob/master/packages/xnft-hotspot/src/components/screens/Swap/Swap.tsx#L55
  2. User now has DC in wallet. User then navigates to account token list and clicks on DC token.
  3. User now has two options: user can click QR code button to scan a QR code that pre-populates Delegate screen or user can click on delegate button.
  4. Finally, user is on the swipe to delegate screen and either has the screen pre-populate via QR code scan or needs to manually fill in recipient address and DC to delegate.
lytzV commented 1 year ago

btw now that we are separating mint & delegate -- there will be a scenario where the user tries to delegate more than what he/she has minted. There should be an error message that prompts the user to mint more DC.