search

helium / wallet-app

Apache License 2.0
59 stars 36 forks source link

Remove transaction audio and animation #740

Open arduino43 opened 4 months ago

arduino43 commented 4 months ago

When a transaction is submitted, at least on iPhone, the audio handed over to the wallet app and stops any other active streams; this seems unnecessary.

The animation also is unnecessary long and creates delays when sending many transaction; I think the default should be to submit and return.

ChewingGlass commented 4 months ago

I don't think we're going to remove the animation but we can remove the audio hijacking. And potentially cut the animation short if it finishes early.

arduino43 commented 3 months ago

I don't think we're going to remove the animation but we can remove the audio hijacking. And potentially cut the animation short if it finishes early.

Thank you. Cutting the animation would be helpful as it isn't really tied to any process, it plays regardless of transaction state; If you submit a transaction and immediately click out of the animation most times the transaction Is already completed while the animation would continue running for another 5 seconds. It's just an added delay for every transaction in most cases.

arduino43 commented 1 month ago

I don't think we're going to remove the animation but we can remove the audio hijacking. And potentially cut the animation short if it finishes early.

Any update on this?