[Feat] support secure url in Helius constructor

helius-labs / helius-sdk

123 stars 39 forks source link

[Feat] support secure url in Helius constructor #87

Closed kAsky53 closed 2 months ago

kAsky53 commented 3 months ago

Breaking changes:

changed Helius.apiKey as optional.
changed constructor parameter with optional object HeliusConfig.

kAsky53 commented 3 months ago

This is PR for #86. @0xIchigo need your review. Thanks!

0xIchigo commented 3 months ago

Thank you for the PR! We've been discussing this internally, and unfortunately, we don't really have the cycles to take care of breaking changes at the moment. I'm going to leave this PR open so that we can discuss it more in the future

kAsky53 commented 3 months ago

Thank you for the PR! We've been discussing this internally, and unfortunately, we don't really have the cycles to take care of breaking changes at the moment. I'm going to leave this PR open so that we can discuss it more in the future

@0xIchigo would it be approved if I make it a fully backward compatible by any chance?

kAsky53 commented 3 months ago

@0xIchigo it should be fully backward compatible as of now. Thanks!