helix-bridge / contracts

MIT License
6 stars 4 forks source link

Fix Reentrancy Vulnerability in `executeTransaction` #82

Open seriousfuzzy opened 4 days ago

seriousfuzzy commented 4 days ago

hello @hackfisher @yrong @hujw77 @WoeOm @xiaoch05 , please check this PR.

Changes:

Testing:

hujw77 commented 4 days ago

Thank you so much for your contribution!

  1. This contract is a fork of the Gnosis MultiSigWallet, and you can also submit this PR to them.
  2. We’ve already switched to using the Gnosis Safe Wallet in the production environment.
  3. The original code already includes reentrancy checks.
  4. This is an older version of the contract, so your modifications may not compile and will need to be adapted for the older solidity compiler.

Given these reasons, we won’t be merging the PR for now.

seriousfuzzy commented 3 days ago

Thank you.