search

helix-collective / hx-terraform

0 stars 4 forks source link

Replace '.' in VPC Endpoint service with '-'. #79

Closed bacek closed 2 years ago

bacek commented 2 years ago

Apparently Endpoint services can contain '.' in the name. For example "ecr.dkp". Which produces incorrect terraform name if used as is.

bacek commented 2 years ago

LGTM.

Better would be that contextTagsWithName should sanitise the strings passed in.

It needs to be an identifier: https://www.terraform.io/docs/language/syntax/configuration.html#identifiers

Actually all "names" should be sanitised. Check the second argument to AR.createVpcEndpoint.