helix-editor / helix

A post-modern modal text editor.
https://helix-editor.com
Mozilla Public License 2.0
31.84k stars 2.35k forks source link

Remove escaping on shell commands #10549

Open kirawi opened 3 months ago

kirawi commented 3 months ago

https://github.com/helix-editor/helix/blob/e18b772654a51afd5c840e32456cb71640c3aa10/helix-term/src/commands/typed.rs#L3126-L3132

We should probably match Kakoune here to special-case shell commands. This would fix issues like https://github.com/helix-editor/helix/discussions/7752

pascalkuthe commented 3 months ago

We do still want to do command expansion for shell commands but kakoune does that tok so matching whatever they do should work

postsolar commented 3 months ago

I find the escaping rules incomprehensible and end up just putting everything into a script even for small one-liner commands, so that I could just do :sh /path/to/script. I would very much welcome just executing shell commands verbatim, except for expansions ofc.