Consider if default theme should have different cursor colors for insert and normal mode

[matklad]

In default configuration helix, like vim, only shows the current mode in the modeline. This is poor UX, especially for new users, as, by just looking at the screen where you edit text, it's impossible to say which mode is active.

A nice solution here is to use different cursor color for different modes. This is available in the, e.g., ayu_evolve theme.

I suggest that the default theme also gets this cursor color distinction, as that would be, imo, a big win for usability for new users (or for old users who don't want to bother with config files).

[pascalkuthe]

The default cursor had mode based cursor colors forever. But a while ago we merged a PR that changed the way the highlight inheritance works (to allow theming the primary cursor different from the other cursors and support mode dependent highlights at the same time).

This broke the default theme. To fix this we would need to simply copy ui.cursor.selection and ui.cursor.insert to ui.cursor.primary.selection and ui.cursor.primary.insert

[Diogenesoftoronto]

It seems no one has linked a pr. I am going to try doing this. Wish me luck will be first PR for helix. :)