helix-editor / helix

A post-modern modal text editor.
https://helix-editor.com
Mozilla Public License 2.0
33.95k stars 2.51k forks source link

[space] menu's FG = BG, if `base16_terminal` on GNOME with black-on-white scheme #10751

Open Rudxain opened 6 months ago

Rudxain commented 6 months ago

Summary

The [space]-menu is unreadable when using that theme while "light-mode" is enabled. I either have to switch to base16_default (which makes the cursor always white, hiding the char below) or use a white-on-black (dark) scheme.

Reproduction Steps

I tried this: 1. `hx` 2. space-bar I expected this to happen: menu is readable, as usual Instead, this happened: foreground (font) and background colors are ~~exactly~~ almost the same (black) ### Helix log _Irrelevant_ ### Platform Linux ### Terminal Emulator ``` # GNOME Terminal 3.46.8 using VTE 0.70.6 +BIDI +GNUTLS +ICU +SYSTEMD ``` ### Installation Method releases page ### Helix Version helix 24.3 (2cadec0b)
Rudxain commented 1 month ago

This problem still happens on helix 24.7 (079f5442). When doing space k to view a "hover hint", the dialog is unreadable too (FG & BG are too similar, causing low contrast)

the-mikedavis commented 1 month ago

I'm not sure this can be fixed in the theme itself. Base16 themes use whatever your terminal has configured for its base16 colors so it should always be possible to configure your terminal colorscheme in a way that makes UI elements hard or impossible to read

Rudxain commented 1 month ago

I've found the real problem: The hx theme unconditionally paints black text, regardless of terminal colors (I can only config the GNOME Terminal base16 palette. AFAIK, there's no way to customize base256 colors)