search

helix-editor / helix

A post-modern modal text editor.
https://helix-editor.com
Mozilla Public License 2.0
33.09k stars 2.46k forks source link

Misalignement in the diagnostic picker #11007

Closed Malphaet closed 3 months ago

Malphaet commented 3 months ago

Summary

The diagnostic picker will start to look cursed as soon a some diagnostics are shown.

Tried to rebuild rust-analyzer, then pick the one from rustup to no avail.

I bisected my issue to commit 8a549b767b24b14ec1abc3d5502c0ee9dd9e0bd1 . Screenshot from 2024-06-21 16-27-10 Screenshot from 2024-06-21 15-44-23

Reproduction Steps

Any build after 8a549b767b24b14ec1abc3d5502c0ee9dd9e0bd1 will have a cursed look for the diagnostic picker on the terminal (gnome-term) or Alacritty (didn't try others) All rusts projects I tried did have this issue, didn't test another language. So the steps are (afaik): ``` hx src/anyfilewithissues.rs +d ``` ### Helix log
~/.cache/helix/helix.log ``` 2024-06-21T15:01:44.904 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) 2024-06-21T15:01:45.023 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) 2024-06-21T15:01:46.512 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) 2024-06-21T15:01:46.512 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) 2024-06-21T15:01:46.512 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) 2024-06-21T15:02:46.793 helix_lsp::transport [ERROR] Tried sending response into a closed channel (id=Num(946)), original request likely timed out 2024-06-21T15:03:26.587 helix_lsp::transport [ERROR] rust-analyzer <- InvalidParams: code action without data 2024-06-21T15:15:05.042 helix_lsp::transport [ERROR] Tried sending response into a closed channel (id=Num(1286)), original request likely timed out 2024-06-21T15:18:23.734 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) 2024-06-21T15:18:23.734 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) 2024-06-21T15:18:23.734 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) 2024-06-21T15:18:23.734 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) 2024-06-21T15:18:23.739 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) 2024-06-21T15:18:23.888 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) ..... 2024-06-21T15:18:26.167 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) 2024-06-21T15:18:26.167 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) 2024-06-21T15:18:26.167 helix_term::ui::markdown [WARN] unhandled markdown event InlineHtml(Borrowed("")) 2024-06-21T15:18:53.230 helix_lsp::transport [ERROR] rust-analyzer <- InvalidParams: code action without data 2024-06-21T15:20:40.787 helix_lsp::transport [ERROR] Tried sending response into a closed channel (id=Num(1709)), original request likely timed out 2024-06-21T15:28:09.667 helix_lsp [ERROR] client was already removed 2024-06-21T15:28:09.670 helix_lsp::transport [ERROR] rust-analyzer err: <- StreamClosed 2024-06-21T15:30:57.546 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T15:37:41.242 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T15:37:54.499 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T15:42:45.613 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T15:44:03.553 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T15:47:24.594 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T15:49:34.521 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T15:51:55.255 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T15:54:28.920 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T15:59:30.221 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:00:40.113 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:00:56.259 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:03:33.885 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:03:39.206 helix_lsp::transport [ERROR] rust-analyzer err <- "error: Unknown binary 'rust-analyzer' in official toolchain '1.74.0-x86_64-unknown-linux-gnu'.\n" 2024-06-21T16:03:39.207 helix_lsp [ERROR] failed to initialize language server: server closed the stream 2024-06-21T16:03:39.207 helix_lsp::transport [ERROR] rust-analyzer err: <- StreamClosed 2024-06-21T16:03:57.961 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:05:54.841 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:09:59.461 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:14:29.846 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:16:00.522 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:17:37.234 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:19:07.661 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:20:13.281 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:21:44.606 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:23:31.674 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:24:21.658 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:26:12.318 helix_view::theme [WARN] Theme: invalid style attribute: underlined 2024-06-21T16:29:40.627 helix_view::theme [WARN] Theme: invalid style attribute: underlined ```
### Platform Pop!_OS 22.04 LTS (linux) ### Terminal Emulator GNOME Terminal 3.44.0 using VTE 0.68.0 +BIDI +GNUTLS +ICU +SYSTEMD ### Installation Method source ### Helix Version helix 24.3 (8a549b76)
kirawi commented 3 months ago

Can you try the latest master? This should have been fixed.

Malphaet commented 3 months ago

Just did and the issue appears to have stopped, I'm baffled tho, as the first thing I remember doing was to fetch the latest version and clean build it. It appears I wasn't thorough enough and must not have fetched the latest version, I apologize for my mistake. Thank you for the swift answer and have a great day.