search

helix-editor / helix

A post-modern modal text editor.
https://helix-editor.com
Mozilla Public License 2.0
33.69k stars 2.5k forks source link

Searching for \0 leaks error message into UI #11213

Open ashfield-kasku opened 3 months ago

ashfield-kasku commented 3 months ago

Summary

If you type /\0<ret> then this will happen:

image

I assume it's not intentional since it's black-on-black in the default theme.

Reproduction Steps

No response

Helix log

No response

Platform

Linux

Terminal Emulator

foot

Installation Method

source

Helix Version

24.07-52-gc34164c0

the-mikedavis commented 3 months ago

That is an instance of a popup component actually, it isn't leaking: https://github.com/helix-editor/helix/blob/c9d829a26dac81a57f18796308d3806d77d0c439/helix-term/src/ui/mod.rs#L136-L160

I believe this is a theme issue with the default theme or the Text component - it depends on which colors your terminal is using. For example with a dark terminal theme and the default Helix theme I see:

bug

ashfield-kasku commented 3 months ago

Ah ok, that makes sense, I'm using a light theme.