Feature request: Toggle minimum diagnostic severity for diagnostic picker

helix-editor / helix

A post-modern modal text editor.

https://helix-editor.com

Mozilla Public License 2.0

33.64k stars 2.5k forks source link

Feature request: Toggle minimum diagnostic severity for diagnostic picker #11245

Open nick42d opened 3 months ago

nick42d commented 3 months ago

When working on a branch with a large number of diagnostic warnings, errors can get drowned out. It would be nice to have a way of toggling this.

languages.toml diagnostic-severity is not suitable, as once I have tackled the errors I would like to toggle and move onto the warnings without editing configuration.

pascalkuthe commented 3 months ago

This would be solved by implementing fzf ORs operator. The last bit of fzf syntax we don't support yet. I have also found myself missing these for other applications. Then you could do $severity err|warn|info for example. I don't think adding a config option is something we would that. We are generally extremely conservative ablut adding config options.

RoloEdits commented 3 months ago

For now, you should be able to enter %sev ERROR to filter that column. But this picker doesnt keep a history of what you entered so you would have to type it each time as you go through them.

pascalkuthe commented 3 months ago

that is the same thing I was saying but only works for error but not for warnings for example (issue is about minimum severisyt not about just showing a single severity). I don't think manually typing a couple of characters into the picker is something that needs a config option

nick42d commented 3 months ago

Cheers both! Learned some things from this;

There are some fzf-like matching options for the picker #5114.
On master the picker is now column based #9647 (I was running Arch latest 24.03) and typing %s ERR will show only errors.
There is a docs PR for some of this functionality open here: #11218.

From my perspective this covers my use case for now. I would generally just want to see errors only or all diagnostics. I will see if I can contribute to the docs PR at all.