Selected word highlighting is basically not visible in the `everblush` theme

[leo-unglaub]

Summary

If you use the everblush theme, the selected word is barley visible. In other themes the contrast is much bigger and better readable.

Reproduction Steps

No response

Helix log

No response

Platform

Linux desktop 6.10.3-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.10.3-1 (2024-08-04) x86_64 GNU/Linux

Terminal Emulator

GNOME Terminal - Version 3.52.2 for GNOME 46 (VTE version 0.77.91 +BIDI +GNUTLS +ICU +SYSTEMD)

Installation Method

Binary from the release page

Helix Version

helix 24.7 (079f5442)

[RoloEdits]

This follows the neovim theme one-for-one as far as I can tell.

helix:

[palette]
black = "#232a2d"

"ui.selection" = { bg = "black" }
"ui.selection.primary" = { bg = "black" }

neovim:

local palette = {
    color0 = '#232a2d',
}

Visual = { fg = p.foreground, bg = p.color0 },

[leo-unglaub]

Ah i see. So do we improve it anyway? Or do we keep it in sync with "upstream" and i create my own custom theme based on everblush? I am not quite sure what your policy is with themes orginating from somewhere else. :)

[RoloEdits]

I don't use the theme, but the main issue seems to be the selection color, and how it interacts with the cursor line highlight and the comment color. Using black-light could improve some contrast against the background in an isolated case, but the comments become pretty unreadable with that color. Perhaps some tweaks to the cursor line color would be the starting point for any change?

As for how to proceed, I don't think the core members would be averse to an improvement for a situation like this that clearly has readability issues, but the spirit of the theme should probably me kept in mind for any changes made.