search

helix-editor / helix

A post-modern modal text editor.
https://helix-editor.com
Mozilla Public License 2.0
34.08k stars 2.52k forks source link

LSP diagnostic is too long if the current window is so narrow #1953

Closed Zaplae closed 4 months ago

Zaplae commented 2 years ago

image

When the diagnostic displays:

image

Zaplae commented 2 years ago

Could it be hidden automatically?

lukepighetti commented 2 years ago

Just ran into this myself. It's very difficult to read the LSP diagnostic. Would be nice if there was a background or border applied to it

Without LSP diagnostic

Screen Shot 2022-04-26 at 2 46 52 PM

With LSP diagnostic

Screen Shot 2022-04-26 at 2 46 58 PM
NoraPerry commented 2 years ago

+1 for some kind of border or coloured background. Depending on the color theme it can be impossible to distinguish where the file contents ends and the diagnostic starts.

0rphee commented 2 years ago

I'd love to have a popup window similar to the one from "Space mode".

Screen Shot 2022-07-11 at 5 35 58 p m Screen Shot 2022-07-11 at 5 33 54 p m
jakenvac commented 1 year ago

I'm not sure this should be labelled enhancement - I would consider that the diagnostics rendering over code to be a bug. Especially so when the code you're trying to fix is obscured by the message.

gabydd commented 1 year ago

Honestly I think this is the best issue: https://github.com/helix-editor/helix/issues/1462 (not labelled bug but it could be)

pascalkuthe commented 1 year ago

It's labeled an enhancement because the code behaves as intended, it's just that other UI options might yield better results. This is sort of an edgecase in terms of labelling but the label won't change the way this issue is treated so it doesn't matter too much.

I closed all other issues except this one and #1462.

1462 is specifically about intrusive diagnostics so I think it made sense to keep one separate issue to also explore alternative solutions like a popup mentinoed above.