search

helix-editor / helix

A post-modern modal text editor.
https://helix-editor.com
Mozilla Public License 2.0
32.82k stars 2.42k forks source link

Make ui.virtual.whitespace more distinct from background for tokio_night #4470

Open lukepighetti opened 1 year ago

lukepighetti commented 1 year ago

Summary

After pressing the w key, the cursor block disappears

https://user-images.githubusercontent.com/666539/197906783-98ae0cb6-4925-42b2-b645-7efe1430cdcc.mov

Reproduction Steps

N/A

Helix log

N/A

Platform

macOS

Terminal Emulator

iTerm Build 3.4.16

Helix Version

helix 22.08.1 (66276ce6)

the-mikedavis commented 1 year ago

It's still there, it's just very faintly visible. This is because of the theme: the foreground color for ui.virtual.whitespace is too close to the ui.background color and ui.cursor.primary has a reversed modifier that switches the ui.virtual.whitespace's foreground to background when the cursor is over whitespace

lukepighetti commented 1 year ago

Theme is tokyonight_storm