search

helix-editor / helix

A post-modern modal text editor.
https://helix-editor.com
Mozilla Public License 2.0
33.65k stars 2.5k forks source link

Invalid hexcodes in several themes `emacs`, `monokai_aqua`, `papercolor-light` (Should be checked in CI at theme PRs?) #5709

Closed LeoniePhiline closed 1 month ago

LeoniePhiline commented 1 year ago

Reproduction:

  1. Open two terminals side by side
  2. In one terminal, watch the hx log: tail -f ~/.cache/helix/helix.log
  3. In the other terminal, open hx
  4. Type :theme
  5. Use the Tab key to go through all themes and observe the log.

Theme emacs

helix_view::theme [WARN] Theme: malformed hexcode: highlight

Theme monokai_aqua

helix_view::theme [WARN] Theme: malformed hexcode: light-black
helix_view::theme [WARN] Theme: malformed hexcode: light-black
helix_view::theme [WARN] Theme: malformed hexcode: purple

Theme papercolor-light

helix_view::theme [WARN] Theme: malformed hexcode: indent

Note: Logging the affected theme's name could be helpful! (Edit: But looking at the code, it seems unwieldy to carry the theme name around as much as would be necessary to log it in case of parsing errors.)

I assume this should be checked in CI via xtask.

sarsapar1lla commented 2 months ago

Does this issue still require attention? If so, happy to take a look at it