search

helix-editor / helix

A post-modern modal text editor.
https://helix-editor.com
Mozilla Public License 2.0
34k stars 2.51k forks source link

Match `m` doesn't respect SELect `v` mode #6435

Open goyalyashpal opened 1 year ago

goyalyashpal commented 1 year ago

Summary

On performing a match action, say, match around ma] the previous selection is overridden despite being in select mode v

Reproduction Steps

```txt ha [character] lorem ha [charact] ipsumen ha [chcter] gypsum ``` 0. Copy above: 1. `hx` 2. `:n` (new buffer) > ` p` (paste) > `gg` (go to top) > `` (ensure in NORmal mode) 3. `j3C` (make multicursors) 4. `v` (SELect mode) 5. `3l` 6. `ma>` (match around >) 7. `2l` 8. `ma]` (match around ]) I expected this to happen: the selection due to `ma` at step 6/8 is added to existing selection to `v` mode Instead, this happened: `ma` overrides previous selection ### Helix log NO!
~/.cache/helix/helix.log ``` please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines ```
### Platform Windows 10 20H2 ### Terminal Emulator wezterm 20230320-124340-559cb7b0 ### Helix Version helix 22.12 (96ff64a8)
adriangalilea commented 7 months ago

I do agree this feels unintuitive