search

helix-editor / helix

A post-modern modal text editor.
https://helix-editor.com
Mozilla Public License 2.0
33.32k stars 2.47k forks source link

Write-quit causes LSP(taplo) errors #8301

Closed TungstenIodide closed 1 year ago

TungstenIodide commented 1 year ago

Summary

When exiting a TOML file with :wq, taplo throws a lot of errors in the log, because of trying to check the file after it gets closed.

Potential solution: don't run LSP checks on write-quit

Reproduction Steps

Install Taplo Open a TOML file Exit with :wq Check the logs

Helix log

2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/foldingRange\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"initialize\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/documentSymbol\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/formatting\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/completion\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/hover\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/documentLink\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/semanticTokens/full\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/rename\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/prepareRename\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"initialized\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"textDocument/didOpen\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"textDocument/didChange\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"textDocument/didSave\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"workspace/didChangeConfiguration\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"workspace/didChangeWorkspaceFolders\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"taplo/convertToJson\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"textDocument/didClose\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"taplo/listSchemas\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"taplo/associatedSchema\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"taplo/convertToToml\"\n"
2023-09-16T14:22:20.100 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"taplo/associateSchema\"\n"
2023-09-16T14:22:20.114 helix_lsp::transport [ERROR] err <- " INFO taplo: LSP server listening transport=\"stdio\"\n"
2023-09-16T14:22:20.115 helix_lsp::transport [ERROR] err <- " WARN taplo:document_open: using detached workspace document_url=file:///home/morbid/.config/helix/themes/monokai_aqua_darker.toml\n"
2023-09-16T14:22:23.846 helix_lsp::transport [ERROR] err <- " INFO taplo: received shutdown request id=Number(1) method=shutdown\n"
2023-09-16T14:22:23.850 helix_lsp::transport [ERROR] err: <- StreamClosed
2023-09-16T14:22:23.850 helix_lsp::transport [ERROR] err: <- Other(failed to send a message to server

Caused by:
    channel closed)

Platform

Linux

Terminal Emulator

Yakuake

Helix Version

23.05

pascalkuthe commented 1 year ago

The initial messages are just messages printed by tablo.

The last error is not reproducible for me. Are you using the latest table version? There were some fixes on their end in the last release that fixed similar issues.

Also are you seeing any issues here besides some errors in the log? Generally log errors are not actually a problem unless real observable issues manifest.