Closed dani0854 closed 10 months ago
It looks like https://github.com/helix-editor/helix/pull/7490 removed the markup.*
scopes for the theme (https://docs.helix-editor.com/master/themes.html#syntax-highlighting) which provide highlighting for things like headers, bold and italic in markdown.
\cc @sharpenedblade
Summary
At some point markdown syntax highlighting has disappeared, and only a couple of elements are still highlighted, while most of the file is white. And it happens only with md files. While all other languages work fine within same helix instance.
I noticed it when I installed markdown LSP, but I couldn't establish any connection. Removing LSP doesn't fix the problem.
What I did find related, is that when
COLORTERM=
then highlighting works in Markdown, though theme doesn't, which to be expected. NormallyCOLORTERM=truecolor
.hx --health markdown
:My config:
Reproduction Steps
I tried this: 1. `RUST_BACKTRACE=1 hx -vv --log log test.md` I expected this to happen: Syntax highlighting of all markdown elements Instead, this happened: Only 2 elements had different colors, like in the picture above ### Helix log~/tmp/hx/log
``` 2023-12-22T02:26:06.564 helix_view::clipboard [DEBUG] Using wl-copy+wl-paste to interact with the system and selection (primary) clipboard 2023-12-22T02:26:06.590 helix_vcs [INFO] Error { context: "failed to open git repo", source: Discover( NoGitRepository { path: "/tmp/hx", }, ), } 2023-12-22T02:26:06.590 helix_vcs [INFO] failed to open diff base for /tmp/hx/test.md 2023-12-22T02:26:06.590 helix_vcs [INFO] Error { context: "failed to open git repo", source: Discover( NoGitRepository { path: "/tmp/hx", }, ), } 2023-12-22T02:26:06.590 helix_vcs [INFO] failed to obtain current head name for /tmp/hx/test.md 2023-12-22T02:26:06.590 helix_lsp::transport [INFO] marksman -> {"jsonrpc":"2.0","method":"initialize","params":{"capabilities":{"general":{"positionEncodings":["utf-8","utf-32","utf-16"]},"textDocument":{"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}},"dataSupport":true,"disabledSupport":true,"isPreferredSupport":true,"resolveSupport":{"properties":["edit","command"]}},"completion":{"completionItem":{"deprecatedSupport":true,"insertReplaceSupport":true,"resolveSupport":{"properties":["documentation","detail","additionalTextEdits"]},"snippetSupport":true,"tagSupport":{"valueSet":[1]}},"completionItemKind":{}},"hover":{"contentFormat":["markdown"]},"inlayHint":{"dynamicRegistration":false},"publishDiagnostics":{"versionSupport":true},"rename":{"dynamicRegistration":false,"honorsChangeAnnotations":false,"prepareSupport":true},"signatureHelp":{"signatureInformation":{"activeParameterSupport":true,"documentationFormat":["markdown"],"parameterInformation":{"labelOffsetSupport":true}}}},"window":{"workDoneProgress":true},"workspace":{"applyEdit":true,"configuration":true,"didChangeConfiguration":{"dynamicRegistration":false},"didChangeWatchedFiles":{"dynamicRegistration":true,"relativePatternSupport":false},"executeCommand":{"dynamicRegistration":false},"inlayHint":{"refreshSupport":false},"symbol":{"dynamicRegistration":false},"workspaceEdit":{"documentChanges":true,"failureHandling":"abort","normalizesLineEndings":false,"resourceOperations":["create","rename","delete"]},"workspaceFolders":true}},"clientInfo":{"name":"helix","version":"23.10 (f6021dd0)"},"processId":42851,"rootPath":"/tmp/hx","rootUri":null,"workspaceFolders":[]},"id":0} 2023-12-22T02:26:06.590 helix_view::editor [DEBUG] editor status: Loaded 1 file. 2023-12-22T02:26:06.590 helix_lsp::client [INFO] Using custom LSP config: {"ltex":{"languageToolHttpServerUri":"http://localhost:8081/"}} 2023-12-22T02:26:06.591 helix_lsp::transport [INFO] ltex-ls -> {"jsonrpc":"2.0","method":"initialize","params":{"capabilities":{"general":{"positionEncodings":["utf-8","utf-32","utf-16"]},"textDocument":{"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}},"dataSupport":true,"disabledSupport":true,"isPreferredSupport":true,"resolveSupport":{"properties":["edit","command"]}},"completion":{"completionItem":{"deprecatedSupport":true,"insertReplaceSupport":true,"resolveSupport":{"properties":["documentation","detail","additionalTextEdits"]},"snippetSupport":true,"tagSupport":{"valueSet":[1]}},"completionItemKind":{}},"hover":{"contentFormat":["markdown"]},"inlayHint":{"dynamicRegistration":false},"publishDiagnostics":{"versionSupport":true},"rename":{"dynamicRegistration":false,"honorsChangeAnnotations":false,"prepareSupport":true},"signatureHelp":{"signatureInformation":{"activeParameterSupport":true,"documentationFormat":["markdown"],"parameterInformation":{"labelOffsetSupport":true}}}},"window":{"workDoneProgress":true},"workspace":{"applyEdit":true,"configuration":true,"didChangeConfiguration":{"dynamicRegistration":false},"didChangeWatchedFiles":{"dynamicRegistration":true,"relativePatternSupport":false},"executeCommand":{"dynamicRegistration":false},"inlayHint":{"refreshSupport":false},"symbol":{"dynamicRegistration":false},"workspaceEdit":{"documentChanges":true,"failureHandling":"abort","normalizesLineEndings":false,"resourceOperations":["create","rename","delete"]},"workspaceFolders":true}},"clientInfo":{"name":"helix","version":"23.10 (f6021dd0)"},"initializationOptions":{"ltex":{"languageToolHttpServerUri":"http://localhost:8081/"}},"processId":42851,"rootPath":"/tmp/hx","rootUri":null,"workspaceFolders":[]},"id":0} 2023-12-22T02:26:06.595 helix_tui::backend::crossterm [DEBUG] The keyboard enhancement protocol is not supported in this terminal (checked in 3.911876ms) 2023-12-22T02:26:06.596 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2023-12-22T02:26:06.745 helix_lsp::transport [ERROR] marksman err <- "[02:26:06 INF]