helix-onchain / filecoin

Collection of libraries to implement common patterns and standards on the Filecoin Virtual Machine
Other
16 stars 14 forks source link

chore: update fvm/ipld crates #212

Closed Stebalien closed 1 year ago

Stebalien commented 1 year ago

I'm also moving all the version specifications to the workspace to ensure we always use the same versions and to make future updates easier.

Stebalien commented 1 year ago

See https://doc.rust-lang.org/cargo/reference/workspaces.html#the-dependencies-table for some context.

coveralls commented 1 year ago

Coverage Status

coverage: 86.913% (+0.1%) from 86.797% when pulling 198e334e89949894be6c135517b2fc0a0b9f749a on steb/update-fvm-ipld into 6aa6c9641c3fef26878597b598eb20862068dc24 on main.

Stebalien commented 1 year ago

So, this is going to be painful. Basically:

We've solved this in ref-fvm by manually building wasm the same way we do in the builtin actors. I have a partial solution to this but..., well, I'll file a PR to demonstrate the issue.

alexytsu commented 1 year ago

I'm also moving all the version specifications to the workspace to ensure we always use the same versions and to make future updates easier.

TIL, thanks.

We've solved this in ref-fvm by manually building wasm the same way we do in the builtin actors. I have a partial solution to this but..., well, I'll file a PR to demonstrate the issue.

I was following https://github.com/filecoin-project/ref-fvm/pull/1718 and https://github.com/filecoin-project/ref-fvm/pull/1698 to update to stable rust here but didn't quite get all the way yet (on branch alex/stable-toolchain)

Stebalien commented 1 year ago

Ah! Awesome. This is the branch I currently have: https://github.com/helix-onchain/filecoin/tree/steb/remove-wasm-builder.

Stebalien commented 1 year ago

Replaced by https://github.com/helix-onchain/filecoin/pull/216.