search

helix-onchain / filecoin

Collection of libraries to implement common patterns and standards on the Filecoin Virtual Machine
Other
16 stars 14 forks source link

`frc42_macros` indirectly depends on `fvm_sdk` and `fvm_shared` #213

Closed lemmih closed 12 months ago

lemmih commented 1 year ago

The frc42_macros crate tries to set the no_sdk feature for frc42_hasher, but that's not enough to avoid the extra dependencies. frc42_hasher uses fvm_sdk by default, so you also need a default-features = false.

Going further, it's better to have additive rather than subtractive features. The frc42_hasher should have a use_sdk feature enabled by default. Would you be interested in a PR for this?

lemmih commented 1 year ago

PR: https://github.com/helix-onchain/filecoin/pull/214