search

helix-onchain / filecoin

Collection of libraries to implement common patterns and standards on the Filecoin Virtual Machine
Other
16 stars 14 forks source link

Update dependencies for Synthetic PoRep support #219

Closed cryptonemo closed 9 months ago

cryptonemo commented 1 year ago

@Stebalien @ZenGround0 : Looks like there was an update last night that I had trouble rebasing against -- I'm not entirely sure what needs to change to be in sync with it at the moment.

Stebalien commented 1 year ago

A version of ref-fvm was released and updated here. What's the ask?

cryptonemo commented 1 year ago

A version of ref-fvm was released and updated here. What's the ask?

What's the correct version to be using? I simply tried rebasing against the latest commit and it broke everything :disappointed:

Stebalien commented 1 year ago

This patch is broken because there's another patch declaration in the Cargo.toml file on master until https://github.com/filecoin-project/builtin-actors/pull/1330 gets merged. Or is something else broken?

cryptonemo commented 1 year ago

Yeah, fixing that -- it's still broken here

Stebalien commented 1 year ago

Could you push? That's why CI is failing.

cryptonemo commented 1 year ago

Could you push? That's why CI is failing.

Pushed, thanks for looking at. Seems something is not patched properly, just not sure what it is at this point (fvm).

coveralls commented 1 year ago

Coverage Status

coverage: 87.128%. remained the same when pulling 3b63d07c7b35b9f72b49bcf71cb58a0a70b933f3 on cryptonemo:synthetic-porep into c1b1183599223f90b93eb4acf2533d5d3f8209fc on helix-onchain:main.

Stebalien commented 1 year ago

Well yes, there's no patch line for the fvm itself.

cryptonemo commented 1 year ago

Well yes, there's no patch line for the fvm itself.

:man_facepalming: Thank you -- sorry, not well versed in the fvm crates and have been staring at patched deps a bit too long.

Stebalien commented 1 year ago

Yeah, I know. I do that all the time. The worst is the FFI where we have two FVM versions...

jennijuju commented 10 months ago

@cryptonemo can we resolve the conflicts plz?

cryptonemo commented 10 months ago

@cryptonemo can we resolve the conflicts plz?

Looking at, but it'll take me a while to figure out the fvm/filecoin deps that have changed. I'll likely need assistance if anyone has some cycles (i.e. @Stebalien , @alexytsu )

For starters, is the alex/update-fvm-ipld branch of https://github.com/helix-onchain/filecoin still the way to go here? I'll have to update the fvm branches too and may find related issues.