helldivers-2 / api

A community driven API for Helldivers 2
https://helldivers-2.github.io/api/
MIT License
219 stars 19 forks source link

[FEATURE]: supported different names of planets #50

Closed weaveul closed 6 months ago

weaveul commented 7 months ago

What problem does it solve

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

The game has different proper names for these planets, which may be confusing when using the API in different countries or locally the name is different

What is the solution

A clear and concise description of what you want to happen.

I suggest it be supported as the API assigning the different languages ​​of the game, like that each person who uses it to load the data in the languages ​​of the game that they have at home

Existing alternatives

A clear and concise description of any alternative solutions or features you've considered.

As an alternative to this I couldn't find anything

Added value

A clear description of the value this feature would add to the community and applications.

This feature could make the API accessible to more people, the developers themselves are not negatively impacted but the target audience could find themselves preferring this API because the languages ​​are supported rather than an API which supports inconsistent names for them

Additional notes

Add any other context or screenshots about the feature request here.

I don't have a screenshot

dealloc commented 7 months ago

Waiting for helldivers-2/json to provide this information

shalzuth commented 7 months ago

Here's a first version - untested. Let me know if you need a different format. The key is the settingsHash from warInfo. planetNames.json I can try to order it to match the indexes later if that'd be helpful. I'll also eventually add planet info to it.

dealloc commented 7 months ago

Given the en version I should be able to map them to the other languages, appreciate the contribution!

dealloc commented 7 months ago

Here's a first version - untested. Let me know if you need a different format. The key is the settingsHash from warInfo. planetNames.json I can try to order it to match the indexes later if that'd be helpful. I'll also eventually add planet info to it.

I've done an initial pass of transformations on it, just need to replace the internal ID's with the ID's from the API planetNames.json

dealloc commented 6 months ago

should be fixed when #69 merges