search

helldivers-2 / json

A set of JSON files for developing applications with Helldivers 2
MIT License
9 stars 10 forks source link

Adjust Premium Warbond Tracking #25

Closed chatterchats closed 4 months ago

chatterchats commented 4 months ago

Remove is_premium from warbonds.json Update Steeled Veterans, Cutting Edge, and Democratic Detonation first page unlock cost to be 1000 Super Credits resolves #21

Stonemercy commented 4 months ago

I had a thought, would it be correct to leave it as medals_to_unlock when it's actually super credits?

Would replacing is_premium with cost_to_unlock and having None for the free ones be better?

chatterchats commented 4 months ago

I'd put the cost of those warbonds in the top-level, thoughts?

I had a thought, would it be correct to leave it as medals_to_unlock when it's actually super credits?

Would replacing is_premium with cost_to_unlock and having None for the free ones be better?

Fair, they should stay medal_to_unlock for consistency. Implementing a change to move them the credit cost to the warbonds.json, basically making this PR a refactor of is_premium property into a credits_to_unlock property