hellerve / programming-talks

Awesome & interesting talks about programming
7.24k stars 503 forks source link

Fixing inter-year-group spacing #70

Closed catb0t closed 5 years ago

catb0t commented 5 years ago

closes #69

New format noted in the contrib paragraph, and I changed <chrono> to &lt;chrono&gt; because GH Markdown sees it as a HTML tag when there is <br> in the file.

Check the rich diff and you'll see what I mean.

hellerve commented 5 years ago

That’s weird, that’s why they are escaped! Anyway, thanks for that fix. I’m not super happy that we have to insert HTML, but there seems to be no other option (usually two empty lines should fix it, but that doesn’t seem to work). Alternatively, we could alternate between list styles, i.e.:

* hi
* also hi

+ bye
+ also bye

which seems to render fine, but is just as ugly if not uglier. I’ll let you voice your opinion before I merge, though!

catb0t commented 5 years ago

Alternating list styles would be cleaner if we could have just the first one be different (although I think it's more complex than <br> to explain anyway). Unfortunately, the entire section has to have one list style, or else they get broken up even without a newline:

* hi
* also hi
+ bye
* also bye
* again bye

gives

It will be harder to maintain and add to if the list style isn't homogenous, and breaks if you put a * instead of +. I don't like it either, but I think <br> is the way to go.

hellerve commented 5 years ago

Alright then, seems like we’ve reached an agreement!

catb0t commented 5 years ago

I think so. :)