search

hello-nrfcloud / firmware

Firmware for devices connecting to nRF Cloud for the out-of-box experience
Other
2 stars 7 forks source link

Report sdkVer #198

Closed coderbyheart closed 4 months ago

coderbyheart commented 4 months ago

Currently sdkVer contains the string APP_VERSION. Report the correct SDK version instead.

{
  "id": "oob-355025930003841",
  "state": {
    "reported": {
      "device": {
        "deviceInfo": {
          "appVersion": "2.0.0-preview8",
          "modemFirmware": "mfw_nrf91x1_2.0.0",
          "board": "thingy91x",
          "sdkVer": "APP_VERSION"
        }
      }
    }
  }
}
simensrostad commented 4 months ago

The nRF Cloud FW library uses a value that is retrieved from the modem info library to set the app version:

In modem_info_params_init() this is set:

modem->device.app_version       = STRINGIFY(APP_VERSION);
simensrostad commented 4 months ago

Fixed in latest version, please verify:

        "modemFirmware":"mfw_nrf91x1_2.0.1"
        "batteryVoltage":4981
        "imei":"355025930003742"
        "board":"thingy91x"
        "sdkVer":"2.7.0-rc2-f5f32227a1df"
        "appName":"N/A"
        "zephyrVer":"v3.6.99-ncs2-rc2-41-g58284ff0e1b8"
        "hwVer":"nRF9151 LACA ADA"
        "appVersion":"0.0.0-dev"

https://github.com/hello-nrfcloud/firmware/releases/tag/v2.0.0-preview.15

coderbyheart commented 4 months ago

image

Works!