search

hello-pangea / color-picker

🎨 React color pickers from Sketch, Photoshop, Chrome, Github, Twitter & more
https://colorpicker.hellopangea.dev
MIT License
63 stars 16 forks source link

Dragging outside of the color picker stops updating the color #23

Open gkiely opened 1 year ago

gkiely commented 1 year ago

In react-color if you click and drag outside of the color picker, it still updates the color. In color-picker the updating stops and the picker freezes.

Example: https://www.loom.com/share/8bc6a40a304944578008b01649638142

gkiely commented 1 year ago

I believe it needs to be updated to use document instead of a reference to the picker. https://github.com/hello-pangea/color-picker/blob/main/packages/color-picker/src/components/common/Saturation.tsx#L45

The calculate change method also needs to be updated. https://github.com/hello-pangea/color-picker/blob/main/packages/color-picker/src/helpers/saturation.js