hello-robot / stretch_ros

ROS packages for the Stretch mobile manipulators from Hello Robot Inc.
https://docs.hello-robot.com/0.2/stretch-tutorials/ros1/
167 stars 84 forks source link

Reduce err thres to prevent immediate goal success #108

Closed hello-chintan closed 11 months ago

hello-chintan commented 11 months ago

When the gripper joint is commanded through the trajectory server in position mode, the goal returns success immediately even before the goal is reached. This is because the error threshold, set at 1.0, is too high for when the gripper is commanded with the ‘gripper_finger_left/right’ joint names through the trajectory server.

E.g. joint_gripper_finger_left reports a position of 0 when fingers barely touch, and when fully open nominally returns 0.22. When the gripper is commanded to open from a zero position the error measurement (goal_pos - current_pos = 0.22 - 0) is already lower than the error threshold (0.22 < 1.0) which sets the goal as successful immediately.

Lowering the threshold to 0.015, the default for a SimpleCommandGroup, prevents this behavior.