Missing cython and numpy dependency in stretch_funmap

hello-robot / stretch_ros2

ROS 2 packages for the Stretch mobile manipulators from Hello Robot Inc.

https://docs.hello-robot.com/0.2/stretch-tutorials/ros2/

51 stars 19 forks source link

Missing cython and numpy dependency in stretch_funmap #114

Open marekmlk opened 2 months ago

marekmlk commented 2 months ago

Hello!

stretch_funmap uses numpy and cython but they are included in package.xml.

Without that information rosdep fails to install all dependencies properly.

Kind regards, Marek

hello-binit commented 1 month ago

Hi @marekmlk, thanks for reporting this. I'd expect Numpy and Cython to be installed on a robot that has already gone through a Stretch Installation (includes cython), which includes installing the Stretch Body Python library (includes numpy).

Have you had issues on a Stretch where these dependencies were missing?

marekmlk commented 1 month ago

Thanks for the reply!

No, I did not faced this issue on the robot but in simulation. I'm relying on rosdep to install all dependencies in Docker container and I stumped upon it.

You are right, cyton and numpyare so popular so it is very unlikely that they are not on the system. However, when building Docker image from scratch it may happen.

I also think that it is good practice to include all possible dependencies in package.xml :)

Kind regards, Marek