search

hello-robot / stretch_urdf

URDFs for the Stretch mobile manipulators from Hello Robot Inc.
Other
6 stars 3 forks source link

`stretch_urdf_ros_update.py` hardcoded for hello-robot user #13

Closed hello-binit closed 5 months ago

hello-binit commented 6 months ago

https://github.com/hello-robot/stretch_urdf/blob/9c9fbeb919cbb3f9df682fe4b6b6a79f9c47410f/tools/stretch_urdf_ros_update.py#L62

If the robot has other users, this tool won't work in those other users.

Artificys commented 5 months ago

Another thing with this, is that when trying to create a new workspace using _stretch_create_amentworkspace.sh, it'll copy the urdf directory to the ament_ws instead of whatever new workspace you're trying to create. Which then crashes the script when 

ros2 run stretch_calibration update_uncalibrated_urdf

Can't find the xacro files inside the new workspace.

hello-binit commented 5 months ago

Thanks @Artificys, good point. And thanks for moving https://github.com/hello-robot/stretch_install/issues/64 here.

I believe @hello-fazil is working on fixing this.

hello-fazil commented 5 months ago

This issue if fixed with the commit https://github.com/hello-robot/stretch_urdf/commit/345cd7b186396d3637403774a3b989dbc1ab29b2