Due to updates in librealsense and the camera firmware, some of the RealSense camera parameters have changed (see more details here). This PR brings the web teleop interface up-to-date with these changes.
NOTE: This PR requires the one-line change from here. Until that is merged in, I'd suggest modifying building realsense_ros from source and manually adding that change.
Testing
[x] On a "new" Stretch (e.g., D405 firmware 5.12.14.100, librealsense v2.55.1, realsense_ros on this commit), verify that this PR addresses the bug:
[x] Pull the master branch of this repo. Rebuild. Launch the web app (i.e., colcon_cd stretch_web_teleop; ./launch_interface.sh). Verify that the gripper RGB image is zoomed in (e.g., the gripper is not visible in the rendered image).
[x] To double-check, run ros2 topic echo /gripper_camera/image_raw | grep width. Verify that it is 848.
[x] Pull this branch (bugfix/multi_camera_launch). Rebuild. Launch the web app. Verify that the gripper RGB image is not zoomed in (e.g., the gripper is visible in the rendered image).
[x] To double-check, run ros2 topic echo /gripper_camera/image_raw | grep width. Verify that it is 480.
[x] On an old Stretch (e.g., one that doesn't have the bug), verify that this PR doesn't break anything:
[x] Pull this branch (bugfix/multi_camera_launch). Rebuild. Launch the web app. Verify that the gripper RGB image is not zoomed in (e.g., the gripper is visible in the rendered image).
[x] To double-check, run ros2 topic echo /gripper_camera/image_raw | grep width. Verify that it is 480.
@hello-vinitha This PR is now ready for review. Can you test this on your Stretch, which didn't have the bug, to verify that it doesn't break anything?
Description
Due to updates in
librealsense
and the camera firmware, some of the RealSense camera parameters have changed (see more details here). This PR brings the web teleop interface up-to-date with these changes.NOTE: This PR requires the one-line change from here. Until that is merged in, I'd suggest modifying building
realsense_ros
from source and manually adding that change.Testing
master
branch of this repo. Rebuild. Launch the web app (i.e.,colcon_cd stretch_web_teleop; ./launch_interface.sh
). Verify that the gripper RGB image is zoomed in (e.g., the gripper is not visible in the rendered image).ros2 topic echo /gripper_camera/image_raw | grep width
. Verify that it is 848.bugfix/multi_camera_launch
). Rebuild. Launch the web app. Verify that the gripper RGB image is not zoomed in (e.g., the gripper is visible in the rendered image).ros2 topic echo /gripper_camera/image_raw | grep width
. Verify that it is 480.bugfix/multi_camera_launch
). Rebuild. Launch the web app. Verify that the gripper RGB image is not zoomed in (e.g., the gripper is visible in the rendered image).ros2 topic echo /gripper_camera/image_raw | grep width
. Verify that it is 480.