hello-robot / stretch_web_teleop

Remote web teleoperation for the Stretch mobile manipulators from Hello Robot Inc.
Other
13 stars 0 forks source link

Allow users to toggle between full and cropped gripper view #48

Closed hello-amal closed 3 months ago

hello-amal commented 3 months ago

Description

This PR, in service of #7 , allows users to expand the Gripper camera view.

This PR also addresses the following (small) bugs in the web interface:

  1. Rotating the wrist sometimes introduced black space in the default gripper view, even though theoretically rotating a rectangle around an inscribed circle should never result in black space. (This was because we rotated the image before cropping it.)
  2. configure_video_streams that did not swap x and y when indexing into OpenCV images. The first index of matrices is the row, which is the vertical dimension of images, e.g.,img[row, col] = img[y, x]. This bug did not impact functionality (since x and y were also swapped in the parameters), but did impact readability.

Testing procedure

Before opening a pull request

From the top-level of this repository, run:

To merge

hello-amal commented 3 months ago

Merging without testing on the "Stretch RE2 + no dex wrist w/ beta teleop kit" configuration because:

  1. I've double-checked the code, plus we've already tested with the beta teleop kit, so I'm fairly confident that it is unlikely to break that test case.
  2. We haven't yet been able to procure that specific configuration.
  3. Few users still use that configuration.