63 temporarily fixed the wrist dropping issue by removing "all" commands to stop the trajectory client. However, it missed one command in robot.tsx. As a result of that, the wrist pitch still drops when toggling the tablet between portrait and landscape (likely amongst other commands). This PR addresses that oversight by also adding a flag to not run that command to stop the trajectory client.
Testing procedure
[x] Verify the issue: Pull on master, have your robot configured with the tablet tool, and launch the interface. Keep toggling the tablet between portrait and landscape, and verify that the wrist pitch drops.
[x] Verify the fix: Pull on this branch, have your robot configured with the tablet tool, and launch the interface. Keep toggling the tablet between portrait and landscape, and verify that the wrist pitch does not drop.
Description
63 temporarily fixed the wrist dropping issue by removing "all" commands to stop the trajectory client. However, it missed one command in
robot.tsx. As a result of that, the wrist pitch still drops when toggling the tablet between portrait and landscape (likely amongst other commands). This PR addresses that oversight by also adding a flag to not run that command to stop the trajectory client.Testing procedure
master, have your robot configured with the tablet tool, and launch the interface. Keep toggling the tablet between portrait and landscape, and verify that the wrist pitch drops.Before opening a pull request
From the top-level of this repository, run:
pre-commit run --all-filesTo merge
Squash & Merge