search

hello-smile6 / neofetch-js

Neofetch for the web.
https://neofetch.vercel.app
GNU General Public License v3.0
5 stars 2 forks source link

web-ify #2

Closed webdev03 closed 2 years ago

webdev03 commented 2 years ago

Not tested yet..

webdev03 commented 2 years ago

This shouldn't pollute the global namespace..

webdev03 commented 2 years ago

You could also use ES6 modules instead.

hello-smile6 commented 2 years ago
  1. Modules aren't an option with local development.
  2. It seems like you have some variables to update. Just use find/replace in vscode to fix those.

Otherwise, looks good.

webdev03 commented 2 years ago

I think that let is scoped to the function only? I'm working on an example in this PR.

hello-smile6 commented 2 years ago

I think that let is scoped to the function only? I'm working on an example in this PR.

I have an example already, going to deploy to vercel and test it.

webdev03 commented 2 years ago

Oh

hello-smile6 commented 2 years ago

@webdev03 Adding vercel, could you make a PR with what's needed to make vercel be quiet?

webdev03 commented 2 years ago

Example doesn't work - You don't need to use XTerm just simple CSS will do!

hello-smile6 commented 2 years ago

Example doesn't work - You don't need to use XTerm just simple CSS will do!

I always use xtermjs for anything that has a CLI-like user interface. Also, if this is used with Node, it needs support for different line endings.

hello-smile6 commented 2 years ago

Made the change I needed to do

webdev03 commented 2 years ago

It's window.Neofetch and it is capital to prevent some confusion with other variables

hello-smile6 commented 2 years ago

Doesn't work yet

(index):60 
 Uncaught ReferenceError: neofetch is not defined
    at neofetch-js-85ydb6ni…s.vercel.app/:60:14
hello-smile6 commented 2 years ago

Checking page performance, just to make sure there isn't a crazy CPU load increase

hello-smile6 commented 2 years ago

@webdev03 Largest contentful paint can't be calculated by https://web.dev/measure , which is confusing. Otherwise, looks good! I really should remove xtermjs temporarily until I have color support, and maybe even load it async, strip color while it's loading, and re-render with color after it loads once I add color support. Merging, anything you need to change?

hello-smile6 commented 2 years ago

Okay, you haven't responded, so I'm merging.

hello-smile6 commented 2 years ago

Why delete?

webdev03 commented 2 years ago

My fork, my wish 😄

hello-smile6 commented 2 years ago

My fork, my wish 😄

Oh. I never delete branches, and actively undelete them sometimes on github orgs.

hello-smile6 commented 2 years ago

@webdev03 BTW, this is for https://github.com/DustinBrett/daedalOS/discussions/61