hello-smile6 / neofetch-js

Neofetch for the web.
https://neofetch.vercel.app
GNU General Public License v3.0
5 stars 2 forks source link

add ios detection #7

Closed webdev03 closed 2 years ago

webdev03 commented 2 years ago

Not tested!

hello-smile6 commented 2 years ago

Doesn't seem to work, can you test with xcode or something?

webdev03 commented 2 years ago

OK

webdev03 commented 2 years ago

I tested on my iPhone it works even without da8190b

hello-smile6 commented 2 years ago

I tested on my iPhone it works even without da8190b

Okay. If you detect the string "iPad", it should detect iPads. It looked like it didn't have it yet.

hello-smile6 commented 2 years ago

Was just using device emulation in devtools to test, btw

hello-smile6 commented 2 years ago

Looks good, maybe we should alias Neofetch.osList.apple to Neofetch.osList.macos...

webdev03 commented 2 years ago

I'm going to revamp the osList system after this gets merged.

hello-smile6 commented 2 years ago

I'm going to revamp the osList system after this gets merged.

Sounds good

hello-smile6 commented 2 years ago

@webdev03 Why 5500? Why not a port in the first 1024?

webdev03 commented 2 years ago

??

hello-smile6 commented 2 years ago

??

Looking at the analytics data, counter.dev shows .local and local IP addresses for some reason. I'm going to open an issue.

hello-smile6 commented 2 years ago

@webdev03 https://github.com/ihucos/counter.dev/issues/59

hello-smile6 commented 2 years ago

??

Just wanted you to know that it showed that, because it'd be wrong to not tell you.

hello-smile6 commented 2 years ago

I'll add something that'll check for local domains and abort if it finds any.

hello-smile6 commented 2 years ago

@webdev03 https://github.com/hello-smile6/neofetch-js/commit/942b7ed437a0047ad00d7b5dd8416a868cc29aee