Closed benejoseph closed 7 years ago
@plasticchris
What if a user is having trouble, so they are repeating "ok sense" over and over? won't this ensure it never works for them?
why don't you try it?
Ok, tried it and verified it's possible to never trigger while repeating "ok sense" over and over
and what happens if you wait a second?
Also, repeating okay sense over and over doesn't work with the RNN anyway. We've always had to wait a short period if time.
Yes but this is what people do when it doesn't work at first
On Thu, Dec 8, 2016, 1:49 PM Ben notifications@github.com wrote:
also, repeating okay sense over and over doesn't work with the RNN anyway
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/hello/kitsune/pull/712#issuecomment-265865758, or mute the thread https://github.com/notifications/unsubscribe-auth/AHR0tKFN4g174_bWklrzsqnIwOWyE_cVks5rGHtQgaJpZM4LHTRA .
I think we should try this on our master units and get feedback. Perhaps your perception isn't shared by everyone else.
It's not a perception. It's what I've observed happens when the first attempt doesn't trigger. Try watching someone new to the device to see it.
On Thu, Dec 8, 2016, 2:34 PM Ben notifications@github.com wrote:
I think we should try this on our master units and get feedback. Perhaps your perception isn't shared by everyone else.
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/hello/kitsune/pull/712#issuecomment-265876343, or mute the thread https://github.com/notifications/unsubscribe-auth/AHR0tHmdio5vHva25K-PfEXnwNdiiVwUks5rGIYEgaJpZM4LHTRA .
From my anecdotal testing, it feels more responsive. We can adjust the no-speech delay if it's an issue.
Let's get some real feedback by pushing to master.
Ok, but people in master are already conditioned and/or in the training set. This is important, it will drastically impact the new user experience as people get increasingly frustrated and then give up.
It it possible to decouple the VAD gating from the new net?
programatically or at compile time?
Compile time is fine, but it looks like the threshold for ok sense got lowered significantly. It's not clear if the VAD gating is required to make that work.
Barring setting extreme thresholds (0.05 or 0.95), the main influence over false positives is the choice of neural net. This net has more false positives per hour than the previous net by an order of magnitude, but it works across many more speakers in the real world. The VAD gating is an attempt reduce false positives from continuous speech. So I'd like the two to go hand-in-hand. But to disable the VAD gating all you have to do is comment out the "if" statement surrounding the keyword on_end callback in keyword_net.c
don't merge, btw. the VAD gate seems to get stuck.
mmk
closing because we're addressing actual root causes! Yipee!
neural net model
VAD gating