jyfan/question-daily-add

hello / suripu

Suripu スリープ tracks data collected by sensors during sleep.

26 stars 7 forks source link

jyfan/question-daily-add #1900

Closed jykfan closed 7 years ago

jykfan commented 7 years ago

Goal:

Add another daily question. Alternate daily question according to account age.
This new question might be more clinically relevant, so the purpose of this is better data collection

In this PR:

A lot of refactoring. I am moving the logic in QuestionProcessor into the new QuestionCoreProcessor

cc. @benejoseph

jykfan commented 7 years ago

integration with app here https://github.com/hello/suripu-app/pull/296

jykfan commented 7 years ago

Release procedure:

Put under feature flipper in suripu-app. (some users would get only original QuestionProcessor logic and others would get only QuestionCoreProcessor logic)

Will verify most important behavior:

Asks all onboarding questions when account is created
Asks daily questions

benejoseph commented 7 years ago

👍