search

hello / suripu

Suripu γ‚ΉγƒͺγƒΌγƒ— tracks data collected by sensors during sleep.
26 stars 7 forks source link

Jh daysupport 2 #1917

Closed jarred-h closed 7 years ago

jarred-h commented 7 years ago

mvp cc @benejoseph

benejoseph commented 7 years ago

so SleepDay has three SleepPeriodResult, and a SleepPeriodResult is basically a TimelineResult, but with more information. And a SleepPeriod is just morning,afternoon, evening. Am I close here?

benejoseph commented 7 years ago

Change the string for an enum in TimelineResult, I'll +1, test that timeline works as normal on dev, canary, then prod.

benejoseph commented 7 years ago

πŸ‘

pims commented 7 years ago

Minor comments, good to merge πŸ‘

Let's make sure the feature flipper is working as intended before we deploy to prod πŸ˜†