search

helloSystem / Dock

Application dock
GNU General Public License v3.0
18 stars 13 forks source link

Fix for launching from folders containing spaces ("Developer Preview") #20

Closed PreyK closed 2 years ago

PreyK commented 3 years ago

https://github.com/helloSystem/Dock/issues/19 https://github.com/helloSystem/Dock/issues/11 Don't split arguments on whitespaces because whitespace named folders like "3D Apps" won't work. BUT! Filer launches (Utilities, Preferences) rely on splitting on whitespaces so we need to correct the arguments when launching trough filer. Both cases should work now.

The optimal solution would be to leave splitting on whitespaces alltogether (if possible) and use proper args, would need to properly investigate why was it done this way to avoid breaking stuff.

probonopd commented 3 years ago

Thanks @PreyK.

Yes, I think the proper way to do this would be to store an array of args. Hardcoding this for one application (Filer) seems wrong to me ;-)

kettle-7 commented 2 years ago

Maybe do this: keep adding arguments until .app is detected?

probonopd commented 2 years ago

Hi·@PreyK, do you think we could use quotes in the Dock config file and parse those similar to his? This way, we would not need to hardcode one application (Filer). Would appreciate an update of this PR in case you agree. Thanks!

probonopd commented 2 years ago

A different approach using quotes has been implemented now. Hope it works for everyone.