helloSystem / Dock

Application dock
GNU General Public License v3.0
18 stars 13 forks source link

Keeping Firefox to Dock fails, Exec= empty #28

Open rdrms opened 2 years ago

rdrms commented 2 years ago

Hi all, really enjoying the simplicity of this project.

One thing I just ran into is that I put Firefox pinned to the dock, but it won't launch when I open it from there. Other applications I tried seem to work fine. But for some reason, Firefox will launch just fine from the terminal, or from the System menu, but not from the dock.

Also, is there some way to rearrange the items in the dock without removing them all and then adding them again?

Thanks!

probonopd commented 2 years ago

Hello @ryanrms, thanks for your feedback. How did you get the Firefox version you are trying to pin to the Dock?

Currently it is not yet possible to rearrange the Dock items. We should either backport this functionality or switch to CutefishOS Dock entirely (by porting our changes such as Application Bundle support to it).

rdrms commented 2 years ago

I got Firefox through selecting it through the system menu. I believe it was installed through pkg if my memory of the install is correct. Thanks for the reply, good luck!

probonopd commented 2 years ago

Can you please copy and paste here the Firefox section from $HOME/.config/cyberos/dock_pinned.conf?

rdrms commented 2 years ago

So the method I used to add it to the dock was to launch Firefox using the System -> Applications (Internet) menu, then right click the dock and click to add it. It appears it is missing the Exec line:

(...)

[Firefox]
DesktopPath=
Exec=
IconName=firefox
Index=5
visibleName=Mozilla Firefox

(...)
probonopd commented 2 years ago

This is a bug. Please change it to Exec=Firefox and see what happens.

When I do the following, it seems to work for me:

In this case, the resulting entry is

DesktopPath=
Exec='/Applications/Internet/Firefox.app/Firefox'
IconName=file:///Applications/Internet/Firefox.app/Resources/Firefox.png
Index=6
visibleName=Firefox

I can reproduce the bug like this:

[Firefox]
DesktopPath=
Exec=
IconName=firefox
Index=6
visibleName=Mozilla Firefox

So, strangely, adding Firefox to the Dock only works as long as it is not installed.

Need to get down to the root cause of this. Most likely we need a moer robust way to find out which Application Bundle has launched a process.

rdrms commented 2 years ago

Changing the "Exec=" line to "Exec=firefox" opens the browser as expected.

Small note, I wasn't able to get your first method to work. I pinned the Firefox icon to the dock and cancelled the installer, but clicking on it wasn't able to get the installer to start again.